Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent queue notice #324

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Conversation

thenbrent
Copy link
Contributor

The notice displayed to alert an admin about the maximum number of queues being processed used the term "batches", which is incorrect. Even when the queue concurrency has been reached, new batches may be claimed.

It also said "No actions will be processed until", which is incorrect - actions continue to be processed by the active queues, but no additional queues will be initiated.

The notice displayed to alert an admin about the maximum number of
queues being processed used the term "batches", which is incorrect.
Even when the queue concurrency has been reached, new batches may
be claimed.

It said "No actions will be processed until", which is incorrect -
actions continue to be processed by the active queues, but no
additional queues will be initiated.
@thenbrent thenbrent added this to the 3.0.0 milestone Jul 9, 2019
Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thenbrent LGTM 🚢

@rrennick rrennick merged commit 60e1d7f into version_3_0_0 Jul 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix_queue_concurrency_notice branch July 18, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants